RError.com

RError.com Logo RError.com Logo

RError.com Navigation

  • 主页

Mobile menu

Close
  • 主页
  • 系统&网络
    • 热门问题
    • 最新问题
    • 标签
  • Ubuntu
    • 热门问题
    • 最新问题
    • 标签
  • 帮助
主页 / 问题 / 1480064
Accepted
invzbl3
invzbl3
Asked:2022-12-22 06:56:27 +0000 UTC2022-12-22 06:56:27 +0000 UTC 2022-12-22 06:56:27 +0000 UTC

如何重构控制器的 add() 方法?

  • 772

ProjectController我使用下面编写的类的逻辑:

@RestController
@RequestMapping("/project")
public class ProjectController {

    @Autowired
    ProjectRepository projectRepository;

    @Autowired
    ProjectService projectService;

    ProjectAdaptor projectAdaptor = new ProjectAdaptor();

    /**
     * Logger declaration for knowing the flow of execution for debugging
     */
    private static final Logger logger = LoggerFactory.getLogger(ProjectController.class);

    @GetMapping("/projects")
    @Operation(summary = "Get list of all projects")
    public ResponseEntity<List<ProjectDTO>> findAllProjects() {
        logger.info("findAllProjects() is calling...");

        List<ProjectDTO> projectList = projectService.findAllProducts();
        if (projectList.isEmpty()) {
            return new ResponseEntity<>(HttpStatus.NO_CONTENT);
        }
        return new ResponseEntity<>(projectList, HttpStatus.OK);
    }

    @GetMapping(value = "/{companyId}")
    @Operation(summary = "Get list of projects from database based on companyId")
    public @ResponseBody List<ProjectDTO> findAllProjects(@PathVariable("companyId") String companyId,
                                     HttpServletRequest req) throws ErrorHandling {
        logger.info("findAllProjects() is calling : ");
        Long longCompanyId = Long.parseLong(companyId);
        List<Project> projectList = projectService.getAllProjects(longCompanyId);
        logger.info("findAllProjects ProjectList : " + projectList);

        if (projectList != null && !projectList.isEmpty()) {
            return projectAdaptor.databaseModelToUiDtoList(projectList);
        } else {
            throw new ErrorHandling("Project data not present.");
        }
    }

    @PostMapping
    @Operation(summary = "Add new project")
    public ResponseEntity<ProjectDTO> addProject(@RequestBody Project project) {
        logger.info("addProject() is calling...");

        if (project != null) {
            ProjectDTO projectDTO = projectAdaptor.databaseModelToUiDto(project);
            Project entity = projectRepository.save(projectDTO);
            return new ResponseEntity<>(entity, HttpStatus.OK);
        }
        return new ResponseEntity<>(new ProjectDTO("","",""), HttpStatus.BAD_REQUEST);
    }

    @PutMapping
    @Operation(summary = "Updating project")
    public ResponseEntity<ProjectDTO> updateById(@RequestBody Project project) {
        logger.info("updateById() is calling...");

        if (project != null) {
            projectRepository.save(project);
            return new ResponseEntity<>("Updated successfully.", HttpStatus.OK);
        }
        return new ResponseEntity<>(new ProjectDTO("","",""), HttpStatus.BAD_REQUEST);
    }

    @DeleteMapping
    @Operation(summary = "Deleting project")
    public ResponseEntity<ProjectDTO> deleteById(@PathVariable("id") Long id) {
        logger.info("deleteById() is calling...");

        Optional<Project> project = projectRepository.findById(id);
        if (project.isPresent()) {
            projectRepository.deleteById(id);
            return new ResponseEntity<>("Successfully deleted.", HttpStatus.OK);
        }
        return new ResponseEntity<>(new ProjectDTO("","",""), HttpStatus.BAD_REQUEST);
    }
}

如何重构 add 方法时出现问题:

@PostMapping
@Operation(summary = "Add new project")
public ResponseEntity<ProjectDTO> addProject(@RequestBody Project project) {
    logger.info("addProject() is calling...");

    if (project != null) {
        ProjectDTO projectDTO = projectAdaptor.databaseModelToUiDto(project);
        Project entity = projectRepository.save(projectDTO);
        return new ResponseEntity<>(entity, HttpStatus.OK);
    }
    return new ResponseEntity<>(new ProjectDTO("","",""), HttpStatus.BAD_REQUEST);
}

问题是在保存Entity到DTO. 如果是这样,将它放在输入参数中会不会有问题,Entity还是为此重写逻辑更好?

在此处输入图像描述

我将非常感谢你在这件事上的帮助。

如有必要,我也准备提供任何有助于解决此问题的其他信息。

java
  • 1 1 个回答
  • 32 Views

1 个回答

  • Voted
  1. Best Answer
    invzbl3
    2022-12-22T17:15:41Z2022-12-22T17:15:41Z

    结果解决方案:

    @Operation(summary = "Add new project")
    public ResponseEntity<ProjectDTO> addProject(@RequestBody Project project) {
        logger.info("addProject() is calling...");
    
        if (project != null) {
                Project entity = projectRepository.save(project);
                ProjectDTO projectDTO = projectAdaptor.databaseModelToUiDto(entity);
                return new ResponseEntity<>(projectDTO, HttpStatus.OK);
    
        }
        return new ResponseEntity<>(new ProjectDTO("","",""), HttpStatus.BAD_REQUEST);
    }
    
    • 1

相关问题

  • wpcap 找不到指定的模块

  • 如何以编程方式从桌面应用程序打开 HTML 页面?

  • Android Studio 中的 R.java 文件在哪里?

  • HashMap 初始化

  • 如何使用 lambda 表达式通过增加与原点的距离来对点进行排序?

  • 最大化窗口时如何调整元素大小?

Sidebar

Stats

  • 问题 10021
  • Answers 30001
  • 最佳答案 8000
  • 用户 6900
  • 常问
  • 回答
  • Marko Smith

    我看不懂措辞

    • 1 个回答
  • Marko Smith

    请求的模块“del”不提供名为“default”的导出

    • 3 个回答
  • Marko Smith

    "!+tab" 在 HTML 的 vs 代码中不起作用

    • 5 个回答
  • Marko Smith

    我正在尝试解决“猜词”的问题。Python

    • 2 个回答
  • Marko Smith

    可以使用哪些命令将当前指针移动到指定的提交而不更改工作目录中的文件?

    • 1 个回答
  • Marko Smith

    Python解析野莓

    • 1 个回答
  • Marko Smith

    问题:“警告:检查最新版本的 pip 时出错。”

    • 2 个回答
  • Marko Smith

    帮助编写一个用值填充变量的循环。解决这个问题

    • 2 个回答
  • Marko Smith

    尽管依赖数组为空,但在渲染上调用了 2 次 useEffect

    • 2 个回答
  • Marko Smith

    数据不通过 Telegram.WebApp.sendData 发送

    • 1 个回答
  • Martin Hope
    Alexandr_TT 2020年新年大赛! 2020-12-20 18:20:21 +0000 UTC
  • Martin Hope
    Alexandr_TT 圣诞树动画 2020-12-23 00:38:08 +0000 UTC
  • Martin Hope
    Air 究竟是什么标识了网站访问者? 2020-11-03 15:49:20 +0000 UTC
  • Martin Hope
    Qwertiy 号码显示 9223372036854775807 2020-07-11 18:16:49 +0000 UTC
  • Martin Hope
    user216109 如何为黑客设下陷阱,或充分击退攻击? 2020-05-10 02:22:52 +0000 UTC
  • Martin Hope
    Qwertiy 并变成3个无穷大 2020-11-06 07:15:57 +0000 UTC
  • Martin Hope
    koks_rs 什么是样板代码? 2020-10-27 15:43:19 +0000 UTC
  • Martin Hope
    Sirop4ik 向 git 提交发布的正确方法是什么? 2020-10-05 00:02:00 +0000 UTC
  • Martin Hope
    faoxis 为什么在这么多示例中函数都称为 foo? 2020-08-15 04:42:49 +0000 UTC
  • Martin Hope
    Pavel Mayorov 如何从事件或回调函数中返回值?或者至少等他们完成。 2020-08-11 16:49:28 +0000 UTC

热门标签

javascript python java php c# c++ html android jquery mysql

Explore

  • 主页
  • 问题
    • 热门问题
    • 最新问题
  • 标签
  • 帮助

Footer

RError.com

关于我们

  • 关于我们
  • 联系我们

Legal Stuff

  • Privacy Policy

帮助

© 2023 RError.com All Rights Reserve   沪ICP备12040472号-5