主页 / 问题 / 549827
Accepted
Bald
Asked:2020-07-29 18:01:48 +0000 UTC2020-07-29 18:01:48 +0000 UTC

代码优化：在控制器中创建“通用”操作方法

  • 772

我有以下类层次结构

public abstract class OperationItemViewModel
{
    public int Id {get;set;}
    public int OperationId {get;set;}
    public int OperationItemTypeId {get; protected set;}
    //Прочие свойства
}

public class ProgramViewModel : OperationItemViewModel
{
    public ProgramViewModel() { this.OperationItemTypeId = 6;}       
}

public class SetupMapViewModel : OperationItemViewModel
{
    public SetupMapViewModel() { this.OperationItemTypeId = 3;}       
}

和下一个控制器

public class OperationController: Controler
{
    public ActionResult AddProgram(int operationId){}

    [HttpPost]
    public ActionResult AddProgram(ProgramViewModel model, HttpPostedFileBase downloadableFile)
    {
        if(ModelState.IsValid)
        {
            _operationService.AddItem(model);
        }
    }

    public ActionResult AddSetupMap(int operationId){}

    [HttpPost]
    public ActionResult AddSetupMap(SetupMapViewModel model, HttpPostedFileBase downloadableFile)
    {
        if(ModelState.IsValid)
        {
            _operationService.AddItem(model);
        }
    }
}

方法签名AddItem如下所示：

public void AddItem<T>(T item) where T: OperationItemViewModel
{
    var operationItem = //преобразовываем `ViewModel` в `DAO`
    _context.Set<OperationItem>().Add(operationItem);
    _context.SaveChanges();
}

在我的例子中，一切正常，但我不喜欢 Add( Program/SetupMap/... ) 方法主要是复制粘贴。

是否有可能以某种方式优化此代码 - 即 摆脱方法内部的重复？

c#

1 个回答

  1. Best Answer

    选项1。

    [HttpPost]
public ActionResult AddProgram(ProgramViewModel model, HttpPostedFileBase downloadableFile) => Add(model, downloadableFile);
[HttpPost]
public ActionResult AddSetupMap(SetupMapViewModel model, HttpPostedFileBase downloadableFile) => Add(model, downloadableFile);

private ActionResult Add(OperationItemViewModel model, HttpPostedFileBase downloadableFile) 
{
    if(ModelState.IsValid)
    {
        _operationService.AddItem(model);
    }
}

    选项 2

    我们去除了OperationItemViewModel抽象性并去除了层次结构。

    选项 3。

    你可以用 ModelBinder 想到一些东西：

    class OperationItemModelBinder : DefaultModelBinder
{
    public override object BindModel(ControllerContext controllerContext, ModelBindingContext bindingContext)
    {
        if (bindingContext.ModelType == typeof(OperationItemViewModel))
        {
            var realType = /* как-нибудь вычислить */;
            bindingContext.ModelMetadata = ModelMetadataProviders.Current.GetMetadataForType(null, realType );
        }

        return base.BindModel(controllerContext, bindingContext);
    }
}

[ModelBinder(typeof(OperationItemModelBinder))]
public abstract class OperationItemViewModel
{
    // ...
}
    • 2

相关问题